From 74bd6429407c388a9b0add410dba7aa9f37b9440 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Roger=20Pau=20Monn=C3=A9?= Date: Thu, 5 Jul 2018 15:42:59 +0200 Subject: [PATCH] x86/vpt: fix create_periodic_time to check the irq parameter MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Instead of the stale value inside the periodic_time struct. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich --- xen/arch/x86/hvm/vpt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/hvm/vpt.c b/xen/arch/x86/hvm/vpt.c index d5363caec7..a0cc61fd28 100644 --- a/xen/arch/x86/hvm/vpt.c +++ b/xen/arch/x86/hvm/vpt.c @@ -445,8 +445,8 @@ void create_periodic_time( uint64_t period, uint8_t irq, time_cb *cb, void *data) { if ( !pt->source || - (pt->irq >= NR_ISAIRQS && pt->source == PTSRC_isa) || - (pt->irq >= hvm_domain_irq(v->domain)->nr_gsis && + (irq >= NR_ISAIRQS && pt->source == PTSRC_isa) || + (irq >= hvm_domain_irq(v->domain)->nr_gsis && pt->source == PTSRC_ioapic) ) { ASSERT_UNREACHABLE(); -- 2.30.2